Sandipan Das <sandi...@linux.ibm.com> writes: > Since main() does not return a value explicitly, the > return values from FAIL_IF() conditions are ignored > and the tests can still pass irrespective of failures. > This makes sure that we always explicitly return the > correct test exit status. >
Reviewed-by: Aneesh Kumar K.V <aneesh.ku...@linux.ibm.com> > Reported-by: Eirik Fuller <eful...@redhat.com> > Fixes: 1addb6444791 ("selftests/powerpc: Add test for execute-disabled pkeys") > Fixes: c27f2fd1705a ("selftests/powerpc: Add test for pkey siginfo > verification") > Signed-off-by: Sandipan Das <sandi...@linux.ibm.com> > --- > tools/testing/selftests/powerpc/mm/pkey_exec_prot.c | 2 +- > tools/testing/selftests/powerpc/mm/pkey_siginfo.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c > b/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c > index 9e5c7f3f498a..0af4f02669a1 100644 > --- a/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c > +++ b/tools/testing/selftests/powerpc/mm/pkey_exec_prot.c > @@ -290,5 +290,5 @@ static int test(void) > > int main(void) > { > - test_harness(test, "pkey_exec_prot"); > + return test_harness(test, "pkey_exec_prot"); > } > diff --git a/tools/testing/selftests/powerpc/mm/pkey_siginfo.c > b/tools/testing/selftests/powerpc/mm/pkey_siginfo.c > index 4f815d7c1214..2db76e56d4cb 100644 > --- a/tools/testing/selftests/powerpc/mm/pkey_siginfo.c > +++ b/tools/testing/selftests/powerpc/mm/pkey_siginfo.c > @@ -329,5 +329,5 @@ static int test(void) > > int main(void) > { > - test_harness(test, "pkey_siginfo"); > + return test_harness(test, "pkey_siginfo"); > } > -- > 2.25.1