Hi Christophe, I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on v5.13-rc4 next-20210603] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Christophe-Leroy/powerpc-8xx-Allow-disabling-KUAP-at-boot-time/20210603-170313 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-tqm8xx_defconfig (attached as .config) compiler: powerpc-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/95e4b5f2179c23e263e6889852978227583762f5 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Christophe-Leroy/powerpc-8xx-Allow-disabling-KUAP-at-boot-time/20210603-170313 git checkout 95e4b5f2179c23e263e6889852978227583762f5 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): In file included from arch/powerpc/include/asm/kup.h:22, from arch/powerpc/include/asm/uaccess.h:9, from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from include/linux/compat.h:17, from arch/powerpc/kernel/asm-offsets.c:14: arch/powerpc/include/asm/nohash/32/kup-8xx.h: In function 'kuap_is_disabled': >> arch/powerpc/include/asm/nohash/32/kup-8xx.h:18:9: error: implicit >> declaration of function 'static_branch_unlikely' >> [-Werror=implicit-function-declaration] 18 | return static_branch_unlikely(&disable_kuap_key); | ^~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- In file included from arch/powerpc/include/asm/kup.h:22, from arch/powerpc/include/asm/uaccess.h:9, from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from include/linux/compat.h:17, from arch/powerpc/kernel/asm-offsets.c:14: arch/powerpc/include/asm/nohash/32/kup-8xx.h: In function 'kuap_is_disabled': >> arch/powerpc/include/asm/nohash/32/kup-8xx.h:18:9: error: implicit >> declaration of function 'static_branch_unlikely' >> [-Werror=implicit-function-declaration] 18 | return static_branch_unlikely(&disable_kuap_key); | ^~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:117: arch/powerpc/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1227: prepare0] Error 2 make[1]: Target 'modules_prepare' not remade because of errors. make: *** [Makefile:215: __sub-make] Error 2 make: Target 'modules_prepare' not remade because of errors. -- In file included from arch/powerpc/include/asm/kup.h:22, from arch/powerpc/include/asm/uaccess.h:9, from include/linux/uaccess.h:11, from include/linux/sched/task.h:11, from include/linux/sched/signal.h:9, from include/linux/rcuwait.h:6, from include/linux/percpu-rwsem.h:7, from include/linux/fs.h:33, from include/linux/compat.h:17, from arch/powerpc/kernel/asm-offsets.c:14: arch/powerpc/include/asm/nohash/32/kup-8xx.h: In function 'kuap_is_disabled': >> arch/powerpc/include/asm/nohash/32/kup-8xx.h:18:9: error: implicit >> declaration of function 'static_branch_unlikely' >> [-Werror=implicit-function-declaration] 18 | return static_branch_unlikely(&disable_kuap_key); | ^~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:117: arch/powerpc/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1227: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:215: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/static_branch_unlikely +18 arch/powerpc/include/asm/nohash/32/kup-8xx.h 15 16 static __always_inline bool kuap_is_disabled(void) 17 { > 18 return static_branch_unlikely(&disable_kuap_key); 19 } 20 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
