On Thu, Jun 17, 2021 at 11:40:23AM +1000, Nicholas Piggin wrote: > Excerpts from Segher Boessenkool's message of June 17, 2021 9:37 am: > > On Tue, Jun 15, 2021 at 09:05:27AM +1000, Paul Mackerras wrote: > >> This ensures that we don't get a decrementer interrupt arriving before > >> we have set up a handler for it. > > > > Maybe add a comment saying this is setting MSR[EE]=0 for that? Or do > > other bits here matter as well? > > Hmm, it actually clears MSR[RI] as well. > > __hard_irq_disable() is what we want here, unless the MSR[RI] clearing > is required as well, in which case there is __hard_EE_RI_disable().
I don't think it matters if MSR[RI] is set or not here, nothing will try to recover from an actual reboot I hope :-) Segher
