在 2021/8/5 下午3:58, Jiri Slaby 写道:
Hi,
On 04. 08. 21, 4:54, Xianting Tian wrote:
@@ -933,6 +949,16 @@ struct hvc_struct *hvc_alloc(uint32_t vtermno,
int data,
hp->outbuf_size = outbuf_size;
hp->outbuf = &((char *)hp)[ALIGN(sizeof(*hp), sizeof(long))];
+ /*
+ * hvc_con_outbuf is guaranteed to be aligned at least to the
+ * size(N_OUTBUF) by kmalloc().
+ */
+ hp->hvc_con_outbuf = kzalloc(N_OUTBUF, GFP_KERNEL);
+ if (!hp->hvc_con_outbuf)
+ return ERR_PTR(-ENOMEM);
This leaks hp, right?
BTW your 2 patches are still not threaded, that is hard to follow.
yes, thanks, I found the bug, I am preparing to do this in v4.
It is the first time I send series patches(number >1), I checked the
method for sending series patch on LKML.org, I should send '0/2' which
is the history info for series patches.
I will add 0/2 in v4, sorry again for this:(
beside avove things, the solution in this patch is for you? thanks
+
+ spin_lock_init(&hp->hvc_con_lock);
+
tty_port_init(&hp->port);
hp->port.ops = &hvc_port_ops;
thanks,
