On Thu, Jun 12, 2008 at 08:10:47AM -0600, Grant Likely wrote:
[snip]
> > +               [EMAIL PROTECTED] {
> > +                       compatible = "fsl,mpc5121-i2c-ctrl";
> > +                       reg = <0x1760 0x8>;
> > +               };
> > +
> > +               [EMAIL PROTECTED] {
> 
> (nitpick) There is a recommended practice that says node names should
> be generic as much as possible, so I think this should probably be
> [EMAIL PROTECTED]  The compatible value is fine.

If this is a video display device, the recommended generic name is
"[EMAIL PROTECTED]", not "[EMAIL PROTECTED]".

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to