On Friday 13 June 2008 16:57, Anton Vorontsov wrote: > On Fri, Jun 13, 2008 at 02:46:20PM +0200, Laurent Pinchart wrote: > > On Friday 18 April 2008 19:16, Jochen Friedrich wrote: > > > Based on earlier work by Laurent Pinchart. > > > > > > This patch implement GPIO LIB support for the CPM2 GPIOs. > > > > > > Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> > > > Cc: Laurent Pinchart <[EMAIL PROTECTED]> > > > > Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]> > > > > Is there any showstopper or can this one be applied to powerpc-next ? > > One comment below. > > [...] > > > + mm_gc->save_regs = cpm2_gpio32_save_regs; > > > + of_gc->gpio_cells = 1; > > I would strongly suggest to use gpio_cells = 2, otherwise you will not > able to pass GPIO flags (such as active-low etc) without breaking the > compatibility with older trees.
Agreed. Jochen, will you resubmit or should I do it ? -- Laurent Pinchart CSE Semaphore Belgium Chaussee de Bruxelles, 732A B-1410 Waterloo Belgium T +32 (2) 387 42 59 F +32 (2) 387 42 75
pgpd8xa3QyK7q.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
