On Jun 17, 2008, at 9:32 AM, Olof Johansson wrote:
On Jun 17, 2008, at 8:56 AM, Kumar Gala wrote:
On Jun 16, 2008, at 2:26 PM, Olof Johansson wrote:
On Jun 16, 2008, at 10:46 AM, Kumar Gala wrote:
+ .machine_check = machine_check_e500,
+ .platform = "ppc4080",
Do you really want the platform to be this specific?
I need to look at how this is being used. I remember having a
discussion with Paul about this when introduced platform.
It's used by the AUX vector (AT_PLATFORM), i.e. ld.so can use it to
load platform-optimized libraries. As such, you probably want it to
be e500mc instead.
Yeah, already changed it to ppce500mc.
Why make E500MC a config option, if it's so similar? This way you
can't make a kernel with SPE support that can boot on both
e500{,v2} and e500mc...
I need it for the various things that are compile time, like cache
line size, and lwsync support. If we can get rid of it in the
future great.
I got away without doing that on pa6t since we had the same
cacheline size but ppc64 has a larger value by default so all that
hurt by it was some padding/alignment being larger than required.
I'm sure some of the lowend guys won't be happy if you increase the
alignment so raising the default is out of the picture, I agree with
that.
But: since the cacheline is available in cputable, it can still be
used at runtime, so as long as the alignments are large enough,
stuff like the dcbz loops should still be OK (might need an audit
though to make sure there's nothing missed). With that, you could at
least still boot an E500MC kernel on E500.
Its not as simple as that since there are assumptions about how many
bytes a dcbz will clear.
Since I have to have PPC_E500MC I might as well not provide the
option to enable SPE since it doesnt exist on e500mc.
With the above, if the line size is used from cputable you should be
able to boot an e500mc kernel on e500.
This is a goal I have, but we need to work towards it. For example
LWSYNC vs SYNC is a #define right now.
- k
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev
