Re: [PATCH v4 10/11] microblaze: Use is_kernel_text() helper

[Michal Simek]

On 9/30/21 9:11 AM, Kefeng Wang wrote:
> Use is_kernel_text() helper to simplify code.
> 
> Cc: Michal Simek <mon...@monstr.eu>
> Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com>
> ---
>  arch/microblaze/mm/pgtable.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/microblaze/mm/pgtable.c b/arch/microblaze/mm/pgtable.c
> index c1833b159d3b..9f73265aad4e 100644
> --- a/arch/microblaze/mm/pgtable.c
> +++ b/arch/microblaze/mm/pgtable.c
> @@ -34,6 +34,7 @@
>  #include <linux/mm_types.h>
>  #include <linux/pgtable.h>
>  #include <linux/memblock.h>
> +#include <linux/kallsyms.h>
>  
>  #include <asm/pgalloc.h>
>  #include <linux/io.h>
> @@ -171,7 +172,7 @@ void __init mapin_ram(void)
>       for (s = 0; s < lowmem_size; s += PAGE_SIZE) {
>               f = _PAGE_PRESENT | _PAGE_ACCESSED |
>                               _PAGE_SHARED | _PAGE_HWEXEC;
> -             if ((char *) v < _stext || (char *) v >= _etext)
> +             if (!is_kernel_text(v))
>                       f |= _PAGE_WRENABLE;
>               else
>                       /* On the MicroBlaze, no user access
> 

Acked-by: Michal Simek <michal.si...@xilinx.com>

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs