[email protected]>, Linux-sh list <[email protected]>, Fabio 
Estevam <[email protected]>, Helge Deller <[email protected]>, Daniel Lezcano 
<[email protected]>, Jonathan Hunter <[email protected]>, Mathieu 
Desnoyers <[email protected]>, Frederic Weisbecker 
<[email protected]>, Len Brown <[email protected]>, "open list:TENSILICA XTENSA 
PORT \(xtensa\)" <[email protected]>, Sascha Hauer 
<[email protected]>, Vasily Gorbik <[email protected]>, linux-arm-msm 
<[email protected]>, alpha <[email protected]>, 
linux-m68k <[email protected]>, Stafford Horne 
<[email protected]>, Linux ARM <[email protected]>, Chris 
Zankel <[email protected]>, Stephen Boyd <[email protected]>, Dinh Nguyen 
<[email protected]>, Daniel Bristot de Oliveira <[email protected]>, 
Alexander Shishkin <[email protected]>, [email protected], 
Rasmus Villemoes <[email protected]>, Joel Fernandes <
 [email protected]>, Will Deacon <[email protected]>, Boris Ostrovsky 
<[email protected]>, Kevin Hilman <[email protected]>, 
[email protected], Pv-drivers <[email protected]>, "open 
list:SYNOPSYS ARC ARCHITECTURE" <[email protected]>, Mel 
Gorman <[email protected]>, [email protected], Yury Norov 
<[email protected]>, Hans Ulli Kroll <[email protected]>, Vineet 
Gupta <[email protected]>, linux-clk <[email protected]>, Josh Triplett 
<[email protected]>, Steven Rostedt <[email protected]>, 
[email protected], Borislav Petkov <[email protected]>, [email protected], 
Thomas Bogendoerfer <[email protected]>, Parisc List 
<[email protected]>, Sudeep Holla <[email protected]>, Shawn Guo 
<[email protected]>, David Miller <[email protected]>, Rich Felker 
<[email protected]>, Peter Zijlstra <[email protected]>, [email protected], 
Bjorn Andersson <[email protected]>, "H. Peter Anvin" <hp
 [email protected]>, sparclinux <[email protected]>
, "open list:QUALCOMM HEXAGON..." <[email protected]>, linux-riscv 
<[email protected]>, Anton Ivanov 
<[email protected]>, Jonas Bonn <[email protected]>, Richard 
Weinberger <[email protected]>, the arch/x86 maintainers <[email protected]>, 
Russell King - ARM Linux <[email protected]>, Ingo Molnar 
<[email protected]>, Albert Ou <[email protected]>, "Paul E. McKenney" 
<[email protected]>, Heiko Carstens <[email protected]>, Stefan Kristiansson 
<[email protected]>, Openrisc <[email protected]>, 
Paul Walmsley <[email protected]>, "open list:TEGRA ARCHITECTURE 
SUPPORT" <[email protected]>, Namhyung Kim <[email protected]>, 
Andy Shevchenko <[email protected]>, [email protected], 
Juergen Gross <[email protected]>, Michal Simek <[email protected]>, "open 
list:BROADCOM NVRAM DRIVER" <[email protected]>, Palmer Dabbelt 
<[email protected]>, Anup Patel <[email protected]>, Ivan Ko
 kshaysky <[email protected]>, Johannes Berg 
<[email protected]>, linuxppc-dev <[email protected]>
Errors-To: [email protected]
Sender: "Linuxppc-dev" 
<[email protected]>

* Arnd Bergmann <[email protected]> [220608 18:18]:
> On Wed, Jun 8, 2022 at 4:27 PM Peter Zijlstra <[email protected]> wrote:
> >
> > arch_cpu_idle() is a very simple idle interface and exposes only a
> > single idle state and is expected to not require RCU and not do any
> > tracing/instrumentation.
> >
> > As such, omap_sram_idle() is not a valid implementation. Replace it
> > with the simple (shallow) omap3_do_wfi() call. Leaving the more
> > complicated idle states for the cpuidle driver.

Agreed it makes sense to limit deeper idle states to cpuidle. Hopefully
there is some informative splat for attempting to use arch_cpu_ide()
for deeper idle states :)

> I see similar code in omap2:
> 
> omap2_pm_idle()
>  -> omap2_enter_full_retention()
>      -> omap2_sram_suspend()
> 
> Is that code path safe to use without RCU or does it need a similar change?

Seems like a similar change should be done for omap2. Then anybody who
cares to implement a minimal cpuidle support can do so.

Regards,

Tony

Reply via email to