On Thu, Sep 01, 2022 at 09:32:46AM +0000, Christophe Leroy wrote:
> Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit :
> > +int arch_decode_instruction(struct objtool_file *file, const struct
> > section *sec,
> > + unsigned long offset, unsigned int maxlen,
> > + unsigned int *len, enum insn_type *type,
> > + unsigned long *immediate,
> > + struct list_head *ops_list)
> > +{
> > + u32 insn;
> > +
> > + *immediate = 0;
> > + insn = bswap_if_needed(file->elf, *(u32 *)(sec->data->d_buf + offset));
> > + *len = 4;
>
> Should be *len = 8 when insn >> 26 == 1.
But please use ppc_inst_prefixed(). And just use ppc_inst_len() here?
Not having convenience abstraction functions like that will give you
much more work in the future -- currently all prefix insns use primary
opcode 1, sure, and nothing else does; but this can change.
Segher
