November 9, 2022 7:42 PM, "Mike Rapoport" <r...@linux.ibm.com> wrote:
> Hi Yajun, > > On Wed, Nov 09, 2022 at 11:32:27AM +0000, Yajun Deng wrote: > >> November 9, 2022 6:55 PM, "Sachin Sant" <sach...@linux.ibm.com> wrote: >> >> On 09-Nov-2022, at 3:55 PM, Yajun Deng <yajun.d...@linux.dev> wrote: >> >> November 9, 2022 6:03 PM, "Yajun Deng" <yajun.d...@linux.dev> wrote: >> >> Hey Mike, >> >> Sorry, this email should be sent to Sachin but not Mike. >> Please forgive my confusion. So: >> >> Hey Sachin, >> Can you help me test the attached file? >> Please use this new patch instead of the one in memblock tree. >> >> Thanks for the fix. With the updated patch kernel boots correctly. >> >> Thanks for your test results. >> >> Hi Mike, >> Do you have any other suggestions for this patch? If not, I'll send a v3 >> patch. > > Unfortunately I don't think the new version has much value as it does not > really eliminate the second loop in case memory allocation is required. > I'd say the improvement is not worth the churn. > OK, I got it. >> Tested-by: Sachin Sant <sach...@linux.ibm.com <sach...@linux.ibm.com>> >> >> - Sachin > > -- > Sincerely yours, > Mike.
