On 1/11/23 8:59 PM, Vidya Sagar wrote:
>
>
> On 1/12/2023 9:18 AM, Sathyanarayanan Kuppuswamy wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 1/11/23 7:33 PM, Vidya Sagar wrote:
>>> I think we still need bios option. For example, consider a system where
>>> BIOS needs to keep ECRC enabled for integrity reasons but if kernel doesn't
>>> want it for perf reasons, then, kernel can always use 'ecrc=off' option.
>>
>> I agree that "on" and "off" option makes sense. Since the kernel defaults
>> ecrc setting to "bios", why again allow it as a command line option?
>
> Agree. "on" and "off" are fine but "default" is redundant. Do you want me to
> push a change to remove that as part of this patch itself? I think
> it is more like a cleanup and should go separately.
IMO, the "bios" option cleanup and command line update from Bjorn can be in one
patch, and your change could be a separate patch. But it is
up to you and Bjorn.
>
>>
>> --
>> Sathyanarayanan Kuppuswamy
>> Linux Kernel Developer
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
