On 2023-02-24 16:45:45, Sathvika Vasireddy wrote: > On 23/02/23 10:39, Kautuk Consul wrote: > > > Hi Sathvika, > > > Just one question though. Went through the code again and I think > > > that this place shouldn't be proper to insert a SYM_FUNC_END > > > because we haven't entered the guest at this point and the name > > > of the function is kvmppc_hv_entry which I think implies that > > > this SYM_FUNC_END should be at some place after the HRFI_TO_GUEST. > > > > > > What do you think ? > > Any updates on this ? Is there any other way to avoid this warning ? > Hmm, to mark the end of the kvmppc_hv_entry function, I think > SYM_FUNC_END(kvmppc_hv_entry) should be placed before the next symbol, which > is kvmppc_got_guest() in this case. > > However, if you think it needs to be put at a different place, then it does > not make sense to have any other symbols before that. You may want to > consider checking if other macros like SYM_INNER_LABEL() can be used.
SYM_INNER_LABEL works fine for me. I will post a v2 with this change. Thanks! :-) > > - Sathvika >