When SERIAL_8250_CONSOLE is not set but PPC_UDBG_16550=y,
the legacy_serial code references fsl8250_handle_irq, which is
only built when SERIAL_8250_CONSOLE is set.

Be consistent in referencing the used CONFIG_SERIAL_8250*
symbols so that the build errors do not happen.

Prevents these build errors:

powerpc-linux-ld: arch/powerpc/kernel/legacy_serial.o: in function 
`serial_dev_init':
legacy_serial.c:(.init.text+0x2aa): undefined reference to `fsl8250_handle_irq'
powerpc-linux-ld: legacy_serial.c:(.init.text+0x2b2): undefined reference to 
`fsl8250_handle_irq'

Fixes: 66eff0ef528b ("powerpc/legacy_serial: Warn about 8250 devices operated 
without active FSL workarounds")
Signed-off-by: Randy Dunlap <rdun...@infradead.org>
Cc: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
Cc: linux-ser...@vger.kernel.org
Cc: Michael Ellerman <m...@ellerman.id.au>
Cc: Nicholas Piggin <npig...@gmail.com>
Cc: Christophe Leroy <christophe.le...@csgroup.eu>
Cc: linuxppc-dev@lists.ozlabs.org
---
 arch/powerpc/kernel/legacy_serial.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -- a/arch/powerpc/kernel/legacy_serial.c 
b/arch/powerpc/kernel/legacy_serial.c
--- a/arch/powerpc/kernel/legacy_serial.c
+++ b/arch/powerpc/kernel/legacy_serial.c
@@ -508,9 +508,9 @@ static void __init fixup_port_irq(int in
 
        port->irq = virq;
 
-       if (IS_ENABLED(CONFIG_SERIAL_8250) &&
+       if (IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE) &&
            of_device_is_compatible(np, "fsl,ns16550")) {
-               if (IS_REACHABLE(CONFIG_SERIAL_8250)) {
+               if (IS_REACHABLE(CONFIG_SERIAL_8250_CONSOLE)) {
                        port->handle_irq = fsl8250_handle_irq;
                        port->has_sysrq = 
IS_ENABLED(CONFIG_SERIAL_8250_CONSOLE);
                } else {

Reply via email to