On Fri, 2008-07-25 at 03:33 -0400, Grant Likely wrote: > + if (status && (irq != NO_IRQ)) > + dev_err(&ms->master->dev, "spurious irq, status=0x%.2x\n", > + status); > + > + /* Check if there is another transfer waiting */ > + if (list_empty(&ms->queue)) > + return FSM_STOP;
I don't think doing list_empty outside the critical section is totally safe.. You might want to move it down inside the spin_lock() section. > + /* Get the next message */ > + spin_lock(&ms->lock); The part that's a little confusing here is that the interrupt can actually activate the workqueue .. So I'm wondering if maybe you could have this interrupt driven any workqueue driven at the same time? If you could then you would need the above to be spin_lock_irq/spin_lock_irqsave .. Daniel _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
