Michal Suchánek <msucha...@suse.de> writes: > > On Fri, Nov 17, 2023 at 11:14:27PM -0600, Nathan Lynch via B4 Relay wrote: >> + do { >> + blob = papr_vpd_run_sequence(loc_code); >> + if (!IS_ERR(blob)) /* Success. */ >> + break; >> + if (PTR_ERR(blob) != -EAGAIN) /* Hard error. */ >> + break; >> + pr_info_ratelimited("VPD changed during retrieval, retrying\n"); >> + cond_resched(); >> + } while (!fatal_signal_pending(current)); > > this is defined in linux/sched/signal.h which is not included. >
>> +static long papr_vpd_create_handle(struct papr_location_code __user *ulc) >> +{ >> + struct papr_location_code klc; >> + const struct vpd_blob *blob; >> + struct file *file; >> + long err; >> + int fd; >> + >> + if (copy_from_user(&klc, ulc, sizeof(klc))) >> + return -EFAULT; > > This is defined in linux/uaccess.h which is not included. > > Same for the sysparm driver. > > Tested-by: Michal Suchánek <msucha...@suse.de> Thanks, I'll fix these issues and add your T-B to this patch.