> -----Original Message----- > From: Vladimir Oltean <[email protected]> > Sent: Tuesday, October 29, 2024 6:31 PM > To: [email protected]; Radu-Andrei Bulie <[email protected]> > Cc: David S. Miller <[email protected]>; Eric Dumazet > <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni > <[email protected]>; Breno Leitao <[email protected]>; Madalin Bucur > <[email protected]>; Ioana Ciornei <[email protected]>; Christophe > Leroy <[email protected]>; Sean Anderson > <[email protected]>; [email protected]; linuxppc- > [email protected]; [email protected] > Subject: [PATCH net] net: dpaa_eth: print FD status in CPU endianness in > dpaa_eth_fd tracepoint > > Sparse warns: > > note: in included file (through ../include/trace/trace_events.h, > ../include/trace/define_trace.h, > ../drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h): > warning: incorrect type in assignment (different base types) > expected unsigned int [usertype] fd_status > got restricted __be32 const [usertype] status > > We take struct qm_fd :: status, store it and print it as an u32, > though it is a big endian field. We should print the FD status in > CPU endianness for ease of debug and consistency between PowerPC and > Arm systems. > > Though it is a not often used debug feature, it is best to treat it as > a bug and backport the format change to all supported stable kernels, > for consistency. > > Fixes: eb11ddf36eb8 ("dpaa_eth: add trace points") > Signed-off-by: Vladimir Oltean <[email protected]> > --- > Context: > https://lore.kernel.org/oe-kbuild-all/20241028-sticky-refined-lionfish- > b06c0c@leitao/
Acked-by: Madalin Bucur <[email protected]>
