On Thu, Sep 04, 2008 at 11:55:02AM +0200, Matthias Fuchs wrote: >Hi, > >I added support for the Sequoia on-board I2C temperature sensor to the device. >I am not sure if there is any node naming convention for such devices. >The needed I2C driver can be found under drivers/hwmon in the kernel sources, >so I found "hwmon" suitable for the node. > >Do we want to add this to the sequoia dts file? If this is how it should be >done, >I will commit a proper patch.
See comments below. Out of curiosity, do you have a working driver and setup with this? >diff --git a/arch/powerpc/boot/dts/sequoia.dts >b/arch/powerpc/boot/dts/sequoia.dts >index 72d15f0..82fdfdf 100644 >--- a/arch/powerpc/boot/dts/sequoia.dts >+++ b/arch/powerpc/boot/dts/sequoia.dts >@@ -246,13 +246,23 @@ > }; > > IIC0: [EMAIL PROTECTED] { >+ #address-cells = <1>; >+ #size-cells = <0>; > compatible = "ibm,iic-440epx", "ibm,iic"; > reg = <0xef600700 0x00000014>; > interrupt-parent = <&UIC0>; > interrupts = <0x2 0x4>; >+ >+ [EMAIL PROTECTED] { >+ device_type = "hwmon"; We don't need device_type. Particularly not a new one like this. >+ compatible = "analog,ad7414"; Perhaps 'compatible = "analog,ad7417", "amcc,hwmon-440epx";' josh _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev