On Fri, 2008-09-05 at 16:52 -0700, Victor Gallardo wrote: > From: Victor Gallardo <[EMAIL PROTECTED]> > > This patch adds GPCS, SGMII and M88E1112 PHY support > for the AMCC PPC460GT/EX processors.
So if I understand the patch correctly, either there is an *MII PHY in which case phy_address is used, or there's a GPCS one and phy_address is -1 and gpcs_address is used right ? Why not instead always use phy_address, and have a flag indicating whether it's an MII or GPCS PHY ? This would avoid the added gpcs_read/write functions, among other things, and I believe would look cleaner... Or am I missing something ? Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
