On Tue, Jun 17, 2025 at 05:41:09PM -0700, Sohil Mehta wrote: > On 6/17/2025 3:27 PM, Eric Biggers wrote: > > From: Eric Biggers <ebigg...@google.com> > > > > Move the contents of arch/x86/lib/crypto/ into lib/crypto/x86/. > > > > The new code organization makes a lot more sense for how this code > > actually works and is developed. In particular, it makes it possible to > > build each algorithm as a single module, with better inlining and dead > > code elimination. For a more detailed explanation, see the patchset > > which did this for the CRC library code: > > https://lore.kernel.org/r/20250607200454.73587-1-ebigg...@kernel.org/. > > Also see the patchset which did this for SHA-512: > > https://lore.kernel.org/linux-crypto/20250616014019.415791-1-ebigg...@kernel.org/ > > > > This is just a preparatory commit, which does the move to get the files > > into their new location but keeps them building the same way as before. > > Later commits will make the actual improvements to the way the > > arch-optimized code is integrated for each algorithm. > > > > arch/x86/lib/crypto/.gitignore is intentionally kept for now. See > > https://lore.kernel.org/r/CAHk-=whu2fb22rey6+okx1-+nchuwuczepvd0h2md38drjv...@mail.gmail.com/ > > I'll remove it later after some time has passed. > > > > After this change, arch/x86/lib/ has a lone empty directory crypto with > the .gitignore file. > > Instead, would it be cleaner to get rid of the crypto directory > altogether and update the .gitignore of the parent? > > As per the link above, commit 2df0c02dab82 ("x86 boot build: make git > ignore stale 'tools' directory") says this: > > "So when removing directories that had special .gitignore patterns, make > sure to add a new gitignore entry in the parent directory for the no > longer existing subdirectory." > > With that change, > > Reviewed-by: Sohil Mehta <sohil.me...@intel.com>
Yes, that makes sense. I'll do it that way. Thanks! - Eric
