Apologies for that, I had meant to send v3 in and apparently it got dropped. I believe I have addressed the comments in the v3 I just sent in.
Thank you! ----- Original Message ----- > From: "Bjorn Helgaas" <helg...@kernel.org> > To: "Timothy Pearson" <tpear...@raptorengineering.com> > Cc: "Krishna Kumar" <krish...@linux.ibm.com>, "linuxppc-dev" > <linuxppc-dev@lists.ozlabs.org>, "linux-kernel" > <linux-ker...@vger.kernel.org>, "linux-pci" <linux-...@vger.kernel.org>, > "Madhavan Srinivasan" <ma...@linux.ibm.com>, > "Michael Ellerman" <m...@ellerman.id.au>, "christophe leroy" > <christophe.le...@csgroup.eu>, "Naveen N Rao" > <nav...@kernel.org>, "Bjorn Helgaas" <bhelg...@google.com>, "Shawn Anastasio" > <sanasta...@raptorengineering.com>, > "Lukas Wunner" <lu...@wunner.de> > Sent: Friday, July 11, 2025 4:05:10 PM > Subject: Re: [PATCH v2 6/6] pci/hotplug/pnv_php: Enable third attention > indicator > On Fri, Jul 11, 2025 at 01:18:07PM -0500, Timothy Pearson wrote: >> ----- Original Message ----- >> > From: "Krishna Kumar" <krish...@linux.ibm.com> >> > To: "Bjorn Helgaas" <helg...@kernel.org>, "Timothy Pearson" >> > <tpear...@raptorengineering.com> >> > Cc: "linuxppc-dev" <linuxppc-dev@lists.ozlabs.org>, "linux-kernel" >> > <linux-ker...@vger.kernel.org>, "linux-pci" >> > <linux-...@vger.kernel.org>, "Madhavan Srinivasan" <ma...@linux.ibm.com>, >> > "Michael Ellerman" <m...@ellerman.id.au>, >> > "christophe leroy" <christophe.le...@csgroup.eu>, "Naveen N Rao" >> > <nav...@kernel.org>, "Bjorn Helgaas" >> > <bhelg...@google.com>, "Shawn Anastasio" >> > <sanasta...@raptorengineering.com>, >> > "Lukas Wunner" <lu...@wunner.de> >> > Sent: Monday, July 7, 2025 3:01:00 AM >> > Subject: Re: [PATCH v2 6/6] pci/hotplug/pnv_php: Enable third attention >> > indicator >> >> > Thanks all for the review and Thanks a bunch to Timothy for fixing the PE >> > Freeze >> > issue. The hotplug issues are like you fix N issue and N+1 th issue will >> > come >> > with new HW. >> > >> > We had a meeting of around 1.5 -2.0 hr with demo, code review and log >> > review and >> > we decided to let these fixes go ahead. I am consolidating what we >> > discussed - >> > >> > >> > 1. Let these fixes go ahead as it solves wider and much needed customer >> > issue >> > and its urgently needed for time being. We have verified in live demo that >> > nothing is broken from legacy flow and >> > >> > PE/PHB freeze, race condition, hung, oops etc has been solved correctly. >> > Basically it fixes below issues - >> > >> > root-port(phb) -> switch(having4 port)--> 2 nvme devices >> > >> > 1st case - only removal of EP-nvme device (surprise hotplug disables msi >> > at root >> > port), soft removal may work >> > 2nd case - If we remove switch itself (surprise hotplug disable msi at >> > root >> > port) . >> >> Just a quick follow up to see if anything else is needed from my end >> before this merge can occur? > > I was waiting for a v3 to fix at least these: > > - Subject line style matching history in drivers/pci/hotplug/ (use > "git log --oneline" to see it) > > - Broken subject line wrapping into commit log > > - Spelling fixes > > - Comment reformat to match prevailing style > > - Note attention indicator behavior changes in commit log > > - Some minor refactoring > > Basically everything mentioned in the responses to the original > posting. Or was there a v3 that I missed? > > Bjorn
