Rob, Conor, Krzysztof,
Can one of you or someone else help me with below comment from Rob ?
Le 03/09/2025 à 06:58, Christophe Leroy a écrit :
Hi Rob,
Le 02/09/2025 à 23:24, Rob Herring a écrit :
On Mon, Sep 01, 2025 at 02:05:13PM +0200, Christophe Leroy wrote:
Convert QE QPIO devicetree binding to DT schema.
Signed-off-by: Christophe Leroy <[email protected]>
---
v5: New
---
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - fsl,chip-qe-pario-bank
+ - const: fsl,mpc8323-qe-pario-bank
+
snip
+ compatible = "fsl,mpc8360-qe-pario-bank", "fsl,mpc8323-qe-
pario-bank";
Doesn't match the schema.
Can you be more explicit ? Is it the 'mpc8360' ? It is the 'chip'.
bindings/soc/fsl/cpm_qe/qe/par_io.txt was saying:
- compatible : should be "fsl,<chip>-qe-pario-bank", "fsl,mpc8323-qe-
pario-bank".
Which I first translated in yaml as :
properties:
compatible:
items:
- enum:
- fsl,<chip>-qe-pario-bank
- const: fsl,mpc8323-qe-pario-bank
But 'make dt_binding_check' complained about the < > around 'chip' so I
removed them.
How should it be described ?
Here is what we have in existing DTS upstream:
arch/powerpc/boot/dts/fsl/mpc8569mds.dts-
compatible = "fsl,mpc8569-qe-pario-bank",
arch/powerpc/boot/dts/fsl/mpc8569mds.dts:
"fsl,mpc8323-qe-pario-bank";
--
arch/powerpc/boot/dts/fsl/mpc8569mds.dts-
compatible = "fsl,mpc8569-qe-pario-bank",
arch/powerpc/boot/dts/fsl/mpc8569mds.dts:
"fsl,mpc8323-qe-pario-bank";
--
arch/powerpc/boot/dts/kmeter1.dts-
compatible = "fsl,mpc8360-qe-pario-bank",
arch/powerpc/boot/dts/kmeter1.dts:
"fsl,mpc8323-qe-pario-bank";
--
arch/powerpc/boot/dts/mpc832x_rdb.dts:
compatible = "fsl,mpc8323-qe-pario-bank";
--
arch/powerpc/boot/dts/mpc836x_rdk.dts- compatible =
"fsl,mpc8360-qe-pario-bank",
arch/powerpc/boot/dts/mpc836x_rdk.dts:
"fsl,mpc8323-qe-pario-bank";
--
arch/powerpc/boot/dts/mpc836x_rdk.dts- compatible =
"fsl,mpc8360-qe-pario-bank",
arch/powerpc/boot/dts/mpc836x_rdk.dts:
"fsl,mpc8323-qe-pario-bank";
If the problem in the DT schema is the fsl,chip-qe-pario-bank, should I
replace it with the two possible compatible we have in existing DTS, ie
"fsl,mpc8569-qe-pario-bank" and "fsl,mpc8360-qe-pario-bank", or should I
just ignore them are they are useless for the drivers, or else ?
Thanks
Christophe
