On Thu, Oct 16, 2025 at 05:32:28PM -0700, Sean Christopherson wrote:
> Opportunistically pass the spte instead of the pfn, as the API is clearly
> about removing an spte.
>From my perspective, "remove_external_spte" means removing an external SPTE
>(not
a mirror SPTE). So passing in pfn_for_gfn seems reasonable as well.
Additionally, passing in the pfn eliminates potential concerns about incorrect
spte content.
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index 48598d017d6f..7e92aebd07e8 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1855,8 +1855,8 @@ struct kvm_x86_ops {
> void *external_spt);
>
> /* Update external page table from spte getting removed, and flush TLB.
> */
> - int (*remove_external_spte)(struct kvm *kvm, gfn_t gfn, enum pg_level
> level,
> - kvm_pfn_t pfn_for_gfn);
> + void (*remove_external_spte)(struct kvm *kvm, gfn_t gfn, enum pg_level
> level,
> + u64 spte);
Also update set_external_spte?
/* Update the external page table from spte getting set. */
int (*set_external_spte)(struct kvm *kvm, gfn_t gfn, enum pg_level
level,
kvm_pfn_t pfn_for_gfn);
