On 02/25/26 at 02:03pm, Coiby Xu wrote: > This will prevent a compiling failure when CONFIG_CRASH_DUMP is enabled > but CONFIG_CRASH_DM_CRYPT is disabled, > > arch/powerpc/kexec/elf_64.c: In function 'elf64_load': > >> arch/powerpc/kexec/elf_64.c:82:23: error: implicit declaration of > function 'crash_load_dm_crypt_keys' [-Werror=implicit-function-declaration] > 82 | ret = crash_load_dm_crypt_keys(image); > | ^~~~~~~~~~~~~~~~~~~~~~~~ > cc1: some warnings being treated as errors > > Reported-by: kernel test robot <[email protected]> > Closes: > https://lore.kernel.org/oe-kbuild-all/[email protected]/ > Signed-off-by: Coiby Xu <[email protected]> > --- > include/linux/crash_core.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-)
Acked-by: Baoquan He <[email protected]> > > diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h > index d35726d6a415..c1dee3f971a9 100644 > --- a/include/linux/crash_core.h > +++ b/include/linux/crash_core.h > @@ -34,13 +34,6 @@ static inline void arch_kexec_protect_crashkres(void) { } > static inline void arch_kexec_unprotect_crashkres(void) { } > #endif > > -#ifdef CONFIG_CRASH_DM_CRYPT > -int crash_load_dm_crypt_keys(struct kimage *image); > -ssize_t dm_crypt_keys_read(char *buf, size_t count, u64 *ppos); > -#else > -static inline int crash_load_dm_crypt_keys(struct kimage *image) {return 0; } > -#endif > - > #ifndef arch_crash_handle_hotplug_event > static inline void arch_crash_handle_hotplug_event(struct kimage *image, > void *arg) { } > #endif > @@ -96,4 +89,11 @@ static inline void crash_save_cpu(struct pt_regs *regs, > int cpu) {}; > static inline int kimage_crash_copy_vmcoreinfo(struct kimage *image) { > return 0; }; > #endif /* CONFIG_CRASH_DUMP*/ > > +#ifdef CONFIG_CRASH_DM_CRYPT > +int crash_load_dm_crypt_keys(struct kimage *image); > +ssize_t dm_crypt_keys_read(char *buf, size_t count, u64 *ppos); > +#else > +static inline int crash_load_dm_crypt_keys(struct kimage *image) {return 0; } > +#endif > + > #endif /* LINUX_CRASH_CORE_H */ > -- > 2.53.0 >
