On Tue, 31 Mar 2026 23:14:04 +0200, Cássio Gabriel wrote: > > The i2sbus PCM code uses pi->active to constrain the sibling stream to > an already prepared duplex format and rate in i2sbus_pcm_open(). > > That state is set from i2sbus_pcm_prepare(), but the current code only > clears it on close. As a result, the sibling stream can inherit stale > constraints after the prepared state has been torn down. > > Clear pi->active when hw_params() or hw_free() tears down the prepared > state, and set it again only after prepare succeeds. > > Replace the stale FIXME in the duplex constraint comment with a description > of the current driver behavior: i2sbus still programs a single shared > transport configuration for both directions, so mixed formats are not > supported in duplex mode. > > Reported-by: kernel test robot <[email protected]> > Closes: > https://lore.kernel.org/oe-kbuild-all/[email protected]/ > Fixes: f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa") > Cc: [email protected] > Signed-off-by: Cássio Gabriel <[email protected]>
Applied to for-next branch now. Thanks. Takashi
