> On Apr 28, 2026, at 15:17, Mike Rapoport <[email protected]> wrote: > > On Sun, Apr 05, 2026 at 08:52:03PM +0800, Muchun Song wrote: >> Since set_pageblock_order() is only used in mm/mm_init.c now, make it >> static and remove its declaration from mm/internal.h. >> Signed-off-by: Muchun Song <[email protected]> > > The removal of set_pageblock_order() from sparse.c should be moved here as > well :) Will do. > With that > > Reviewed-by: Mike Rapoport (Microsoft) <[email protected]> Thanks. > >> --- >> mm/internal.h | 1 - >> mm/mm_init.c | 4 ++-- >> 2 files changed, 2 insertions(+), 3 deletions(-) > > -- > Sincerely yours, > Mike.
- Re: [PATCH 09/49] mm: panic on memory allocatio... Mike Rapoport
- [PATCH 05/49] mm/sparse: fix missing architecture-specific p... Muchun Song
- [PATCH 04/49] mm/sparse: add a @pgmap parameter to arch vmem... Muchun Song
- [PATCH 10/49] mm: move subsection_map_init() into sparse_ini... Muchun Song
- [PATCH 11/49] mm: defer sparse_init() until after zone initi... Muchun Song
- [PATCH 12/49] mm: make set_pageblock_order() static Muchun Song
- Re: [PATCH 12/49] mm: make set_pageblock_order() static Mike Rapoport
- Re: [PATCH 12/49] mm: make set_pageblock_order() st... Muchun Song
- [PATCH 13/49] mm: integrate sparse_vmemmap_init_nid_late() i... Muchun Song
- [PATCH 15/49] mm/hugetlb: free cross-zone bootmem gigantic p... Muchun Song
- [PATCH 16/49] mm/hugetlb: initialize vmemmap optimization in... Muchun Song
- [PATCH 14/49] mm/cma: validate hugetlb CMA range by zone at ... Muchun Song
- [PATCH 18/49] mm/mm_init: make __init_page_from_nid() static Muchun Song
- [PATCH 17/49] mm: remove sparse_vmemmap_init_nid_late() Muchun Song
- [PATCH 19/49] mm/sparse-vmemmap: remove the VMEMMAP_POPULATE... Muchun Song
