> On Wed, 6 May 2026 13:15:29 +0200 Holger Brunck wrote: > > When the device is removed all allocated resources should be freed. > > In uhdlc_memclean the netdev transmit queue was already stopped. But > > at this point we may have pending skb in the transmit queue which must > > be freed. Therefore iterate over the tx_skbuff pointers and free all > > pending skb. The issue was discovered by sashiko. > > And you tested this how? > > Given the questionable v1 I'm highly hesitant to accept patches from you if > you > can't test them.
I tested the patch on a ls1043a board running HDLC in busmode on kernel 6.12 I was able to queue some packets in the TX part simply in removing the TX clock for my setup. When I then shutdown the interface and remove the module I can see that thel sk_buff pointers stored in the priv->tx_skbuff array, are not freed without the patch in question. I am currently not able to run my setup on latest master, but the changes in the driver compared to master are minimal. Best regards Holger
