When krealloc() fails, free the original esi_buf before returning to
avoid a memory leak.

Fixes: 3c14b73454cf ("powerpc/pseries: Interface to represent PAPR firmware 
attributes")
Cc: [email protected]
Signed-off-by: Thorsten Blum <[email protected]>
---
 arch/powerpc/platforms/pseries/papr_platform_attributes.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/papr_platform_attributes.c 
b/arch/powerpc/platforms/pseries/papr_platform_attributes.c
index ff8adda02341..aacdaa1ebf63 100644
--- a/arch/powerpc/platforms/pseries/papr_platform_attributes.c
+++ b/arch/powerpc/platforms/pseries/papr_platform_attributes.c
@@ -271,11 +271,9 @@ static int __init papr_init(void)
                esi_buf_size = ESI_HDR_SIZE + (CURR_MAX_ESI_ATTRS * 
max_esi_attrs);
 
                temp_esi_buf = krealloc(esi_buf, esi_buf_size, GFP_KERNEL);
-               if (temp_esi_buf)
-                       esi_buf = temp_esi_buf;
-               else
-                       return -ENOMEM;
-
+               if (!temp_esi_buf)
+                       goto out_free_esi_buf;
+               esi_buf = temp_esi_buf;
                goto retry;
        }
 

Reply via email to