Re: [PATCH v3] PCI: pnv_php: Add null checks for OpenCAPI PHBs

[Nikhil Kumar Singh]

Hi Aditya,

The added NULL checks for OpenCAPI/direct PHB slots make sense. The 
patch looks overall good to me but I have one question about below change:

On 09/06/26 14:19, Aditya Gupta wrote:
+       if (!bridge) {
+               *state = 0;
+               return 0;
+       }
+

Is returning success with an indicator state of 0 the expected behaviour 
for slots without a bridge, or would returning an error such as 
-EOPNOTSUPP(Operation Not Supported) or -ENODEV(No Such Device) be more 
appropriate?

Thanks,
~ Nikhil