On 7/29/26 8:24 AM, Dave Marquardt wrote: > Tyrel Datwyler <[email protected]> writes: > >> @@ -1530,8 +1538,14 @@ static void ibmvfc_set_login_info(struct ibmvfc_host >> *vhost) >> login_info->max_cmds = cpu_to_be32(max_cmds); >> login_info->capabilities = cpu_to_be64(IBMVFC_CAN_MIGRATE | >> IBMVFC_CAN_SEND_VF_WWPN); >> >> - if (vhost->mq_enabled || vhost->using_channels) >> + if (vhost->mq_enabled || vhost->using_channels) { >> login_info->capabilities |= >> cpu_to_be64(IBMVFC_CAN_USE_CHANNELS); >> + if (vhost->nvme_enabled) { >> + login_info->capabilities |= >> cpu_to_be64(IBMVFC_YES_NVMEOF); >> + login_info->capabilities |= >> cpu_to_be64(IBMVFC_YES_SCSI); >> + login_info->capabilities |= >> cpu_to_be64(IBMVFC_CAN_USE_WWPN_ALL); >> + } >> + } > > Should setting IBMVFC_YES_SCSI be conditioned on vhost->nvme_enabled?
Probably not since we always support SCSI protocol, and the extened async handling via subq's is dependent on one or the other being set. -Tyrel > > -Dave >
