On Sat, Oct 10, 2026 at 10:53:01PM +0530, Aditya Garg wrote:
> Jason reported that since commit eddba19b8b5f ("PCI/AER: Support Advisory
> Non-Fatal Errors"), the Macs with Apple T2 Security Chip were powering
> off a few seconds after every boot. He also found the PCI Device
> 106b:1802, which corresponds to the Apple T2 Secure Enclave Processor was
> misbehaving and the most likely reason is that the device is ANFE
> incompatible due to Apple's custom hardware.Nit: Not sure what "misbehaving" means beyond the sudden power-off? > +++ b/drivers/pci/pcie/aer.c > @@ -428,7 +428,8 @@ void pci_aer_init(struct pci_dev *dev) > * Advisory Non-Fatal Errors are masked by default (PCIe r7.0, sec > * 7.8.4.6). > */ > - if (pcie_aer_is_native(dev) && dev->devcap & PCI_EXP_DEVCAP_RBER) > + if (pcie_aer_is_native(dev) && dev->devcap & PCI_EXP_DEVCAP_RBER && > + !dev->no_aer_anfe) > pci_clear_and_set_config_dword(dev, > dev->aer_cap + PCI_ERR_COR_MASK, > PCI_ERR_COR_ADV_NFAT, 0); Nit: The "!dev->no_aer_anfe" is not aligned with the opening brace. It's probably not necessary to respin for the nits alone because Bjorn may resolve them when applying the patch. Reviewed-by: Lukas Wunner <[email protected]>
