On Nov 5, 2008, at 10:42 PM, Paul Mackerras wrote:
Milton Miller writes:
With the new generic smp call function helpers, I noticed the code in
smp_message_recv was a single function call in many cases. While
getting the message number from the ipi data is easy, we can reduce
the path length by a function and data dependent switch by registering
separate ipi actions for these simple calls.
With this I get:
CC arch/powerpc/kernel/smp.o
arch/powerpc/kernel/smp.c: In function 'smp_request_message_ipi':
arch/powerpc/kernel/smp.c:177: error: 'ipi_names' undeclared (first
use in this function)
arch/powerpc/kernel/smp.c:177: error: (Each undeclared identifier is
reported only once
arch/powerpc/kernel/smp.c:177: error: for each function it appears in.)
make[2]: *** [arch/powerpc/kernel/smp.o] Error 1
I think you need smp_ipi_name rather than ipi_names here:
+ WARN(err < 0, "unable to request_irq %d for %s (rc %d)\n",
+ virq, ipi_names[msg], err);
You are exactly correct. I changed my mind on the name of this
varable, and missed this spot on the final edit. However, my compile
passed because it was during the time that the powerpc version of WARN
was never evaluating its printf arguments.
I wrote and compile tested the change, but need to find or setup a
mailer to send it.
milton
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
