Hi Mark,
Thank you for your review.
> >
> > - ret = fsl_sai_reset_hw(dev);
> > - if (ret < 0)
> > - dev_warn(dev, "Failed to reset hardware: %d\n", ret);
> > + fsl_sai_reset_hw(dev);
>
> This is the only caller of fsl_sai_reset_hw(), it could just return void
> now.
>
You're right.
I'll change fsl_sai_reset_hw() to return void.
Since this series has already been applied,
I'll send this as a separate patch.
> > ret = devm_request_irq(dev, irq, fsl_sai_isr, IRQF_SHARED,
> > np->name, sai);
> > - if (ret) {
> > - dev_err(dev, "failed to claim irq %u\n", irq);
> > + if (ret)
> > goto err_pm_get_sync;
> > - }
>
> This will only print an error for a subset of errors, things like -EBUSY
> will now silently fail.
>
>From what I can see in the code, devm_request_irq() ->
devm_request_threaded_irq() reports every failure via dev_err_probe()
in devm_request_result(), so -EBUSY should be printed too.
Could you please point me to the path that fails silently?
I may have missed it.
Or did you mean fsl_sai_read_dlcfg()? It does have some silent
-EINVAL returns.
I'll restore that dev_err() together with the fsl_sai_reset_hw()
change I mentioned earlier.
Best regards,
Phuc
