On Thu, 2009-01-15 at 22:34 +1100, Paul Mackerras wrote: > Michael Ellerman writes: > > > There's quite a lot of code that does: > > > > if (ppc_md.progress) > > ppc_md.progress(...) > > > > So move that idiom into a wrapper. Having a wrapper also allows us > > to have a fallback to printk if no progress routine is specified. > > It certainly used to be the case on ppc32 (and may still be) that > ppc_md.progress was called very very early, in some cases before the > MMU was set up, so we don't want to call printk from it. Falling back > to udbg_printf would be more appropriate.
Except on some platforms udbg_printf() doesn't work. And all the platforms that care still can and do use udbg_progress(). This just saves us having several implementations of progress that just call printk(). cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev