> -----Original Message----- > From: Fleming Andy-AFLEMING > Sent: Monday, January 26, 2009 3:08 PM > To: Anton Vorontsov > Cc: Jeff Garzik; David Miller; Haruki Dai-R35557; [email protected]; > [email protected] > Subject: Re: [PATCH] gianfar: Revive VLAN support > > > On Jan 26, 2009, at 2:50 PM, Anton Vorontsov wrote: > > > commit 77ecaf2d5a8bfd548eed3f05c1c2e6573d5de4ba ("gianfar: Fix VLAN > > HW feature related frame/buffer size calculation") wrongly removed > > priv->vlgrp assignment, and now priv->vlgrp is always NULL. > > > > This patch fixes the issue, plus fixes following sparse warning > > introduced by the same commit: > > gianfar.c:1406:13: warning: context imbalance in > > 'gfar_vlan_rx_register' - wrong count at exit > > > > gfar_vlan_rx_register() checks for "if (old_grp == grp)" and tries > > to return w/o dropping the lock. > > > > According to net/8021q/vlan.c VLAN core issues rx_register() callback: > > 1. In register_vlan_dev() only on a newly created group; > > 2. In unregister_vlan_dev() only if the group becomes empty. > > > > Thus the check in the gianfar driver isn't needed. > > > > Signed-off-by: Anton Vorontsov <[email protected]> > > Acked-by: Andy Fleming <[email protected]>
Acked-by: Dai Haruki <[email protected]> _______________________________________________ Linuxppc-dev mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-dev
