Dear Grant Likely, In message <fa686aa40905061337w6aa82f5aj787618ba108e5...@mail.gmail.com> you wrote: > > > The FEC on 5121 has problems with misaligned tx buffers. > > The RM says any alignment is ok but empirical results > > show that packet buffers ending in 0x1E will sometimes > > hang the FEC. Other bad alignment does not hang but will > > cause silent TX failures resulting in about a 1% packet > > loss as tested by ping -f from a remote host. > > > > This patch is a work around that copies every tx packet > > to an aligned skb before sending. > > OUCH!
Yes :-( > > +#else > > +#define tx_skb_align_workaround(dev, skb) (skb) > > +#endif > > Another use of #ifdef blocks. What is the multiplatform impact? Hm... Can you recommend a better way to solve the problem? Suggestions are welcome. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You don't have to worry about me. I might have been born yesterday... but I stayed up all night. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
