Arnd Bergmann wrote: > On Saturday 23 May 2009, Wolfgang Grandegger wrote: >> Arnd Bergmann wrote: >>> Minor nitpicking: dev->base_addr should be defined as an __iomem pointer >>> so you can avoid the cast here and in the ioremap/iounmap path. >> Here the member "base_addr" of "struct net_device" is used and it's not >> up to me to change the type. > > Right, that makes sense. However, most drivers use the field to store the > physical address, not the iomap token. Maybe there should be a new field > in struct sja1000_priv for the virtual address, but that would be a change > to the base driver, not just to the OF portion.
Is that common practice? If yes, I will add a member to store the virtual address to struct sja1000_priv. Wolfgang. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
