Re: [PATCH V5 3/5] AC97 driver for mpc5200

Tue, 26 May 2009 07:11:14 -0700 

Jon Smirl wrote:

> +static void psc_ac97_warm_reset(struct snd_ac97 *ac97)
> +{
> +     int rc;
> +     struct mpc52xx_psc __iomem *regs = psc_dma->psc_regs;
> +
> +     out_be32(&regs->sicr, psc_dma->sicr | MPC52xx_PSC_SICR_AWR);
> +     spin_event_timeout(0, 3, 0, rc);

I still think you should use udelay() here.  spin_event_timeout(<constant>) 
will just reduce to a udelay() call anyway.  In addition, there's no "event" 
that you're waiting for.

-- 
Timur Tabi
Linux kernel developer at Freescale
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to