On Thu, Jun 11, 2009 at 08:10:41PM +0200, Heiko Schocher wrote:
> The following series implements basic board support for
> the kmeter1 board from keymile, based on a MPC8360.
[snip]
> + par...@1400 {
> + reg = <0x1400 0x100>;
> + device_type = "par_io";
This should have a compatible value instead of a device_type value.
[snip]
> + num-ports = <7>;
> +
> + pio_ucc1: ucc_...@00 {
Since these nodes have addresses, they should also have reg
properties. And the parent should have #address-cells and
#size-cells.
[snip]
> + q...@100000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + device_type = "qe";
This device_type should not be here.
> + compatible = "fsl,qe";
> + ranges = <0x0 0x100000 0x100000>;
> + reg = <0x100000 0x480>;
> + clock-frequency = <0>; /* Filled in by U-Boot */
> + brg-frequency = <0>; /* Filled in by U-Boot */
> + bus-frequency = <0>; /* Filled in by U-Boot */
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
