On Fri, Jun 19, 2009 at 09:26:08AM +0200, Rini van Zetten wrote:
> This patch adds the possibility to have a spi device without a cs.
>
> For example, the dts file should look something like this:
>
> spi-controller {
> gpios = <&pio1 1 0 /* cs0 */
> 0 /* cs1, no GPIO */
> &pio2 2 0>; /* cs2 */
>
> Signed-off-by: Rini van Zetten <r...@arvoo.nl>
> ---
> Changes :
> patch against 2.6.30-rc8-mm1
> style updates
> compiler warning fix
> comment :
> This feature is needed on our home made board to program an onboard
> fpga.
> The fpga needs some special pin toggling to put it in programming mode.
> That's why we want to skip the usual gpio cs and do the pin toggling
> in our driver
Cool, thanks for the explanation. You may want to put it
into the commit message.
[...]
> + ret = gpio_direction_output(pinfo->gpios[i],
> + pinfo->alow_flags[i]);
> + if (ret) {
> + dev_err(dev, "can't set output direction for"
> + "gpio #%d: %d\n",
> + i, ret);
There is no space between 'for' and 'gpio' words.
(also the whole dev_err() may fit into two lines, no need to
split it into three lines).
Otherwise looks great. On the next resend feel free to add my
Acked-by: Anton Vorontsov <avoront...@ru.mvista.com>
Thanks,
--
Anton Vorontsov
email: cbouatmai...@gmail.com
irc://irc.freenode.net/bd2
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
