Hi Albert,

+asm ("\n\


A file scope asm?!  Please don't.

+ * We enter with the cache enabled, the MMU enabled and some known legacy
+ * memory mappings active. xBAT3 is unused

It would be good if you could depend as little as possible on these things;
that makes writing another bootloader a lot easier.

+       /* IBAT3,DBAT3 for first 16Mbytes */\n\
+       li      8, 0x01ff       /* 16MB */\n\
+       li      9, 0x0002       /* rw */\n\
+       mtspr   0x216, 8        /* IBAT3U */\n\
+       mtspr   0x217, 9        /* IBAT3L */\n\
+       mtspr   0x21e, 8        /* DBAT3U */\n\
+       mtspr   0x21f, 9        /* DBAT3L */\n\

WIMG=0000, are you sure?  Not M=1?

+       bcl-    20,4*cr7+so,1f\n\

Just write  bcl 20,31,1f .


Segher

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to