The recently introduced cpu_hotplug_driver_lock used to serialize
cpu hotplug operations, namely for the pseries platform, causes a build
issue for other platforms. The base cpu hotplug code attempts
to take this lock, but it may not be needed for all platforms. This patch
moves the lock/unlock routines to be part of the ppc_md structure
so that platforms needing the lock can take it. This also makes the
previous cpu_hotplug_driver_lock, defined in pseries code, pseries specific.
The past failure without this patch was seen when building pmac and may
be present in other platform builds. The error is included below for reference.
drivers/built-in.o: In function `.store_online':
cpu.c:(.ref.text+0xf5c): undefined reference to `.cpu_hotplug_driver_lock'
cpu.c:(.ref.text+0xfc8): undefined reference to `.cpu_hotplug_driver_unlock'
make: *** [.tmp_vmlinux1] Error 1
Signed-of-by: Nathan Fontenot <nf...@austin.ibm.com>
---
arch/powerpc/include/asm/machdep.h | 2 ++
arch/powerpc/kernel/smp.c | 14 ++++++++++++++
arch/powerpc/platforms/pseries/dlpar.c | 6 ++++--
3 files changed, 20 insertions(+), 2 deletions(-)
Index: powerpc/arch/powerpc/include/asm/machdep.h
===================================================================
--- powerpc.orig/arch/powerpc/include/asm/machdep.h 2009-12-21
20:51:49.000000000 -0600
+++ powerpc/arch/powerpc/include/asm/machdep.h 2009-12-21 21:07:40.000000000
-0600
@@ -270,6 +270,8 @@
#ifdef CONFIG_ARCH_CPU_PROBE_RELEASE
ssize_t (*cpu_probe)(const char *, size_t);
ssize_t (*cpu_release)(const char *, size_t);
+ void (*cpu_hotplug_driver_lock)(void);
+ void (*cpu_hotplug_driver_unlock)(void);
#endif
};
Index: powerpc/arch/powerpc/platforms/pseries/dlpar.c
===================================================================
--- powerpc.orig/arch/powerpc/platforms/pseries/dlpar.c 2009-12-21
20:51:49.000000000 -0600
+++ powerpc/arch/powerpc/platforms/pseries/dlpar.c 2009-12-21
21:26:23.000000000 -0600
@@ -346,12 +346,12 @@
static DEFINE_MUTEX(pseries_cpu_hotplug_mutex);
-void cpu_hotplug_driver_lock()
+static void pseries_cpu_hotplug_driver_lock(void)
{
mutex_lock(&pseries_cpu_hotplug_mutex);
}
-void cpu_hotplug_driver_unlock()
+static void pseries_cpu_hotplug_driver_unlock(void)
{
mutex_unlock(&pseries_cpu_hotplug_mutex);
}
@@ -550,6 +550,8 @@
{
ppc_md.cpu_probe = dlpar_cpu_probe;
ppc_md.cpu_release = dlpar_cpu_release;
+ ppc_md.cpu_hotplug_driver_lock = pseries_cpu_hotplug_driver_lock;
+ ppc_md.cpu_hotplug_driver_unlock = pseries_cpu_hotplug_driver_unlock;
return 0;
}
Index: powerpc/arch/powerpc/kernel/smp.c
===================================================================
--- powerpc.orig/arch/powerpc/kernel/smp.c 2009-12-21 20:51:49.000000000
-0600
+++ powerpc/arch/powerpc/kernel/smp.c 2009-12-21 21:24:23.000000000 -0600
@@ -619,4 +619,18 @@
if (smp_ops->cpu_die)
smp_ops->cpu_die(cpu);
}
+
+#ifdef CONFIG_ARCH_CPU_PROBE_RELEASE
+void cpu_hotplug_driver_lock(void)
+{
+ if (ppc_md.cpu_hotplug_driver_lock)
+ ppc_md.cpu_hotplug_driver_lock();
+}
+
+void cpu_hotplug_driver_unlock(void)
+{
+ if (ppc_md.cpu_hotplug_driver_unlock)
+ ppc_md.cpu_hotplug_driver_unlock();
+}
#endif
+#endif /* CONFIG_HOTPLUG_CPU */
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
