On Wed, Jan 06, 2010 at 12:04:22PM -0600, Scott Wood wrote: > On Thu, Dec 31, 2009 at 10:10:45PM -0800, Ira W. Snyder wrote: > > The name fsl_chan seems too long, so it has been shortened to fchan. > > Could be just "chan", no need for namespacing here. >
True. A few functions have a parameter "struct dma_chan *chan" from the DMAEngine API. I tried to keep the name different to avoid confusing readers of the code. Would you recommend changing everything to "struct fsldma_chan *chan", and changing to "struct dma_chan *_chan" for the DMAEngine stuff? It seems fine to me, and the compiler will warn about mismatched types if you screw something up. The struct dma_chan isn't used for anything except container_of() anyway. Ira _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
