On Sat, Jan 9, 2010 at 4:01 AM, Alexey Dobriyan <adobri...@gmail.com> wrote: > On Thu, Jan 07, 2010 at 01:19:13PM +1100, Jeremy Kerr wrote: >> Commit e22f628395432b967f2f505858c64450f7835365 introduced a build >> breakage for ARM devtree work: the THIS_MODULE macro was added, but we >> don't have module.h >> >> This change adds the necessary #include to get THIS_MODULE defined. >> While we could just replace it with NULL (PROC_FS is a bool, not a >> tristate), using THIS_MODULE will prevent unexpected breakage if we >> ever do compile this as a module. > > I'd say, remove .owner line. > It definitely not needed in non-modular code.
No. Jeremy's fix is the better one. Having the .owner line doesn't cost anything and it is better to have it populated; even if only as an example. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev