Hi Grant,
On Sun, 2 May 2010 08:54:26 -0600
Grant Likely <grant.lik...@secretlab.ca> wrote:
> Hi Anatolij,
>
> Comments below.
>
> On Fri, Apr 30, 2010 at 2:30 PM, Anatolij Gustschin <ag...@denx.de> wrote:
> > Adds IFM PDM360NG device tree, and platform code.
...
> > + n...@40000000 {
> > + compatible = "fsl,mpc5121-nfc";
> > + reg = <0x40000000 0x100000>;
> > + interrupts = <0x6 0x8>;
> > + interrupt-parent = <0x1>;
>
> This looks wrong. Shouldn't this be interrupt-parent = <&ipic>? In
> fact, if the root node has interrupt-parent = <&ipic> then the
> interrupt-parent property can be omitted from all other nodes unless
> they need to override it.
Yes, it should be interrupt-parent = <&ipic>. I will fix it, thanks.
...
> > + // IPIC
> > + // interrupts cell = <intr #, sense>
> > + // sense values match linux IORESOURCE_IRQ_* defines:
> > + // sense == 8: Level, low assertion
> > + // sense == 2: Edge, high-to-low change
> > + //
> > + ipic: interrupt-control...@c00 {
> > + compatible = "fsl,mpc5121-ipic", "fsl,ipic";
> > + interrupt-controller;
> > + #address-cells = <0>;
>
> Don't need #address-cells here
Ok, will remove.
...
> > + m...@2800 {
> > + compatible = "fsl,mpc5121-fec-mdio";
> > + reg = <0x2800 0x200>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + phy: ethernet-...@0 {
> > + reg = <0x1f>;
> > + device_type = "ethernet-phy";
>
> Remove device_type
Ok.
> > + ether...@2800 {
> > + device_type = "network";
>
> Ditto
Removing this property results in not functional ethernet,
in particular, the MAC address won't be set by U-Boot. I need
to add aliases node for ethernet0 to fix this. Ok, will remove
this device_type, too.
Thanks,
Anatolij
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
