Dear Rupjyoti Sarmah, In message <201006041226.o54cqh2v017...@amcc.com> you wrote: > This patch enables the on-chip DWC SATA controller of the AppliedMicro > processor 460EX. > > Signed-off-by: Rupjyoti Sarmah <rsar...@appliedmicro.com> > Signed-off-by: Mark Miesfeld <mmiesf...@appliedmicro.com> > Signed-off-by: Prodyut Hazarika <phazar...@appliedmicro.com> > > --- > drivers/ata/Kconfig | 9 + > drivers/ata/Makefile | 1 + > drivers/ata/sata_dwc_460ex.c | 1808 > ++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 1818 insertions(+), 0 deletions(-) > create mode 100644 drivers/ata/sata_dwc_460ex.c
This driver needs fixing. It will not compile against recent kernel versions. ... > diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c > new file mode 100644 > index 0000000..e6e2896 > --- /dev/null > +++ b/drivers/ata/sata_dwc_460ex.c > @@ -0,0 +1,1808 @@ ... > +#include <linux/kernel.h> > +#include <linux/module.h> > +#include <linux/init.h> > +#include <linux/device.h> > +#include <linux/of_platform.h> > +#include <linux/libata.h> > +#include "libata.h" > + > +#include <scsi/scsi_host.h> > +#include <scsi/scsi_cmnd.h> You miss a "#include <linux/slab.h>" here. ... > + for (i = 0; i < SATA_DWC_QCMD_MAX; i++) > + hsdevp->cmd_issued[i] = SATA_DWC_CMD_ISSUED_NOT; > + > + ap->prd = 0; /* set these so libata doesn't use them */ > + ap->prd_dma = 0; s/prd/bmdma_prd/ in these two lines (cf. commit f60d7011). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de He had quite a powerful intellect, but it was as powerful like a locomotive, and ran on rails and was therefore almost impossible to steer. - Terry Pratchett, _Lords and Ladies_ _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
