On Mon, 2010-08-02 at 10:55 +1000, Benjamin Herrenschmidt wrote: > Replace nvram_create_os_partition() with a variant that takes > the partition name, signature and size as arguments. > > Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> > --- > arch/powerpc/kernel/nvram_64.c | 46 +++++++++++++++++++------------ > arch/powerpc/platforms/pseries/nvram.c | 6 ++-- > 2 files changed, 31 insertions(+), 21 deletions(-) > > diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c > index a8154f1..974b3ec 100644 > --- a/arch/powerpc/kernel/nvram_64.c > +++ b/arch/powerpc/kernel/nvram_64.c > @@ -307,13 +307,15 @@ static int __init nvram_remove_os_partition(void) > return 0; > } > > -/* nvram_create_os_partition > - * > - * Create a OS linux partition to buffer error logs. > - * Will create a partition starting at the first free > - * space found if space has enough room. > +/** > + * nvram_create_partition - Create a partition in nvram > + * @name: name of the partition to create > + * @sig: signature of the partition to create > + * @req_size: size to allocate preferrably > + * @min_size: minimum acceptable size (0 means req_size) > */ > -static int __init nvram_create_os_partition(void) > +static int __init nvram_create_partition(const char *name, int sig, > + int req_size, int min_size) > {
Order of args is req , min but... > + rc = nvram_create_partition("ppc64,linux", NVRAM_SIG_OS, > + NVRAM_MIN_REQ, NVRAM_MAX_REQ); > if (rc) { I call it the other way around :-) I should have tested this more before sending for RFC :-) Anyways, I found more crap, like the way the list head is allocated etc... I'll do another pass this week after I've dealt with the merge window. Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev