> -----Original Message----- > From: Anton Vorontsov [mailto:cbouatmai...@gmail.com] > Sent: Friday, September 03, 2010 19:44 PM > To: Zang Roy-R61911 > Cc: linux-...@lists.infradead.org; Lan Chunhe-B25806; linuxppc-...@ozlabs.org; > a...@linux-foundation.org; Gala Kumar-B11780; Wood Scott-B07421 > Subject: Re: [PATCH 2/3][MTD] P4080/nand: Only make elbc nand driver detect > nand flash partitions > > On Fri, Aug 06, 2010 at 10:51:35AM +0800, Roy Zang wrote: > [...] > > > > +static struct fsl_elbc_fcm_ctrl *elbc_fcm_ctrl; > > + > > Are you sure that you want it as a global var? A bit scary change. > > Oh, you probably don't need it, as you can get it from > fsl_lbc_ctrl_dev->nand? Get it form fsl_lbc_ctrl_dev->nand or assign it to fsl_lbc_ctrl_dev->nand in probe? Thanks. Roy
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
