On Dec 3, 2010, at 6:34 AM, Li Yang wrote:
> The timebase sync is not only necessary when using KEXEC. It should also
> be used by normal boot up and cpu hotplug. Remove the ifdef added by
> the KEXEC patch. Fix a problem that cpu hotplugging freezes the whole system.
>
> Signed-off-by: Jin Qing <b24...@freescale.com>
> Singed-off-by: Li Yang <le...@freescale.com>
> ---
> arch/powerpc/platforms/85xx/smp.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
But we have problems with KEXEC w/o this? What is the issue with hotplugging
and the generic timebase code? When do we freeze?
>
> diff --git a/arch/powerpc/platforms/85xx/smp.c
> b/arch/powerpc/platforms/85xx/smp.c
> index 5c91a99..1e8aec8 100644
> --- a/arch/powerpc/platforms/85xx/smp.c
> +++ b/arch/powerpc/platforms/85xx/smp.c
> @@ -2,7 +2,7 @@
> * Author: Andy Fleming <aflem...@freescale.com>
> * Kumar Gala <ga...@kernel.crashing.org>
> *
> - * Copyright 2006-2008 Freescale Semiconductor Inc.
> + * Copyright 2006-2010 Freescale Semiconductor Inc.
> *
> * This program is free software; you can redistribute it and/or modify it
> * under the terms of the GNU General Public License as published by the
> @@ -115,10 +115,8 @@ smp_85xx_setup_cpu(int cpu_nr)
>
> struct smp_ops_t smp_85xx_ops = {
> .kick_cpu = smp_85xx_kick_cpu,
> -#ifdef CONFIG_KEXEC
> .give_timebase = smp_generic_give_timebase,
> .take_timebase = smp_generic_take_timebase,
> -#endif
> };
>
> #ifdef CONFIG_KEXEC
> --
> 1.6.6-rc1.GIT
>
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
