On 29.11.2010 [12:38:41 +1100], Benjamin Herrenschmidt wrote: > On Tue, 2010-10-26 at 20:35 -0700, Nishanth Aravamudan wrote: > > The iommu_table pointer in the pci auxiliary struct of device_node has > > not been used by the iommu ops since the dma refactor of > > 12d04eef927bf61328af2c7cbe756c96f98ac3bf, however this code still uses > > it to find tables for dlpar. By only setting the PCI_DN iommu_table > > pointer on nodes with dma window properties, we will be able to quickly > > find the node for later checks, and can remove the table without looking > > for the the dma window property on dlpar remove. > > The answer might well be yes but are we sure this works with busses & > devices that don't have a dma,window ? ie. we always properly look for > parents when assigning pci devices arch_data iommu table ? Did you test > it ? :-) (Best way is to find a card with a P2P bridge on it).
So I spent quite a while looking for some device or bus that didn't have "ibm,dma-window" and the boxes I have access to didn't contain any :/ I did test dlpar remove now on p6 and it worked fine. Thanks, Nish -- Nishanth Aravamudan <n...@us.ibm.com> IBM Linux Technology Center _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev